checkout: do not corrupt HEAD on empty repo
In abe1998
("git checkout -b: allow switching out of an unborn
branch"), a code-path overly-optimisticly assumed that a
branch-name was specified. This is not always the case, and as
a result a NULL-pointer was attempted printed to .git/HEAD.
This could lead to at least two different failure modes:
1) vsnprintf formated the NULL-string as something useful (e.g
"(null)")
2) vsnprintf crashed
Neither were very convenient for formatting a new HEAD-reference.
To fix this, reintroduce some strictness so we only take this
new codepath if a banch-name was specified.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
abe199808c
commit
8338f771fe
@ -1100,7 +1100,7 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)
|
||||
if (opts.writeout_stage)
|
||||
die(_("--ours/--theirs is incompatible with switching branches."));
|
||||
|
||||
if (!new.commit) {
|
||||
if (!new.commit && opts.new_branch) {
|
||||
unsigned char rev[20];
|
||||
int flag;
|
||||
|
||||
|
Reference in New Issue
Block a user