auto-gc: extract a reusable helper from "git fetch"
Back in 1991006c
(fetch: convert argv_gc_auto to struct argv_array,
2014-08-16), we taught "git fetch --quiet" to pass the "--quiet"
option down to "gc --auto". This issue, however, is not limited to
"fetch":
$ git grep -e 'gc.*--auto' \*.c
finds hits in "am", "commit", "merge", and "rebase" and these
commands do not pass "--quiet" down to "gc --auto" when they
themselves are told to be quiet.
As a preparatory step, let's introduce a helper function
run_auto_gc(), that the caller can pass a boolean "quiet",
and redo the fix to "git fetch" using the helper.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
@ -218,6 +218,11 @@ LAST_ARG_MUST_BE_NULL
|
||||
int run_hook_le(const char *const *env, const char *name, ...);
|
||||
int run_hook_ve(const char *const *env, const char *name, va_list args);
|
||||
|
||||
/*
|
||||
* Trigger an auto-gc
|
||||
*/
|
||||
int run_auto_gc(int quiet);
|
||||
|
||||
#define RUN_COMMAND_NO_STDIN 1
|
||||
#define RUN_GIT_CMD 2 /*If this is to be git sub-command */
|
||||
#define RUN_COMMAND_STDOUT_TO_STDERR 4
|
||||
|
Reference in New Issue
Block a user