mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

reftable/blocksource: refactor code to match our coding style

Browse Source 
Refactor `reftable_block_source_from_file()` to match our coding style
better.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt
2024-01-11 11:06:52 +01:00
committed by Junio C Hamano
parent 6fdfaf15a0
commit 85e72be15d
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
reftable/blocksource.c
View File

@ -125,24 +125,23 @@ static struct reftable_block_source_vtable file_vtable = {
int reftable_block_source_from_file(struct reftable_block_source *bs, int reftable_block_source_from_file(struct reftable_block_source *bs,
const char *name) const char *name)
{ {
struct stat st = { 0 }; struct file_block_source *p;
int err = 0; struct stat st;
int fd = open(name, O_RDONLY); int fd;
struct file_block_source *p = NULL;
fd = open(name, O_RDONLY);
if (fd < 0) { if (fd < 0) {
if (errno == ENOENT) { if (errno == ENOENT)
return REFTABLE_NOT_EXIST_ERROR; return REFTABLE_NOT_EXIST_ERROR;
}
return -1; return -1;
} }
err = fstat(fd, &st); if (fstat(fd, &st) < 0) {
if (err < 0) {
close(fd); close(fd);
return REFTABLE_IO_ERROR; return REFTABLE_IO_ERROR;
} }
p = reftable_calloc(sizeof(struct file_block_source)); p = reftable_calloc(sizeof(*p));
p->size = st.st_size; p->size = st.st_size;
p->fd = fd; p->fd = fd;