commit: factor out clear_commit_marks_for_object_array
Factor out the code to clear the commit marks for a whole struct object_array from builtin/checkout.c into its own exported function clear_commit_marks_for_object_array and use it in bisect and bundle as well. It handles tags and commits and ignores objects of any other type. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
1062141928
commit
86a0a408b9
7
bisect.c
7
bisect.c
@ -818,7 +818,7 @@ static int check_ancestors(const char *prefix)
|
||||
{
|
||||
struct rev_info revs;
|
||||
struct object_array pending_copy;
|
||||
int i, res;
|
||||
int res;
|
||||
|
||||
bisect_rev_setup(&revs, prefix, "^%s", "%s", 0);
|
||||
|
||||
@ -835,10 +835,7 @@ static int check_ancestors(const char *prefix)
|
||||
res = (revs.commits != NULL);
|
||||
|
||||
/* Clean up objects used, as they will be reused. */
|
||||
for (i = 0; i < pending_copy.nr; i++) {
|
||||
struct object *o = pending_copy.objects[i].item;
|
||||
clear_commit_marks((struct commit *)o, ALL_REV_FLAGS);
|
||||
}
|
||||
clear_commit_marks_for_object_array(&pending_copy, ALL_REV_FLAGS);
|
||||
free(pending_copy.objects);
|
||||
|
||||
return res;
|
||||
|
||||
Reference in New Issue
Block a user