parse_pathspec: support stripping/checking submodule paths
PATHSPEC_SYMLINK_LEADING_PATH and _STRIP_SUBMODULE_SLASH_EXPENSIVE are respectively the alternate implementation of pathspec.c:die_if_path_beyond_symlink() and pathspec.c:check_path_for_gitlink(). They are intended to replace those functions when builtin/add.c and builtin/check-ignore.c are converted to use parse_pathspec. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
b69bb3fc27
commit
8745024422
26
pathspec.c
26
pathspec.c
@ -214,6 +214,26 @@ static unsigned prefix_pathspec(struct pathspec_item *item,
|
||||
match[item->len] = '\0';
|
||||
}
|
||||
|
||||
if (flags & PATHSPEC_STRIP_SUBMODULE_SLASH_EXPENSIVE)
|
||||
for (i = 0; i < active_nr; i++) {
|
||||
struct cache_entry *ce = active_cache[i];
|
||||
int ce_len = ce_namelen(ce);
|
||||
|
||||
if (!S_ISGITLINK(ce->ce_mode))
|
||||
continue;
|
||||
|
||||
if (item->len <= ce_len || match[ce_len] != '/' ||
|
||||
memcmp(ce->name, match, ce_len))
|
||||
continue;
|
||||
if (item->len == ce_len + 1) {
|
||||
/* strip trailing slash */
|
||||
item->len--;
|
||||
match[item->len] = '\0';
|
||||
} else
|
||||
die (_("Pathspec '%s' is in submodule '%.*s'"),
|
||||
elt, ce_len, ce->name);
|
||||
}
|
||||
|
||||
if (limit_pathspec_to_literal())
|
||||
item->nowildcard_len = item->len;
|
||||
else
|
||||
@ -329,6 +349,12 @@ void parse_pathspec(struct pathspec *pathspec,
|
||||
unsupported_magic(entry,
|
||||
item[i].magic & magic_mask,
|
||||
short_magic);
|
||||
|
||||
if ((flags & PATHSPEC_SYMLINK_LEADING_PATH) &&
|
||||
has_symlink_leading_path(item[i].match, item[i].len)) {
|
||||
die(_("pathspec '%s' is beyond a symbolic link"), entry);
|
||||
}
|
||||
|
||||
if (item[i].nowildcard_len < item[i].len)
|
||||
pathspec->has_wildcard = 1;
|
||||
pathspec->magic |= item[i].magic;
|
||||
|
||||
Reference in New Issue
Block a user