mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

builtin/: add UNLEAKs

Browse Source 
Add some UNLEAKs where we are about to return from `cmd_*`. UNLEAK the
variables in the same order as we've declared them. While addressing
`msg` in builtin/tag.c, convert the existing `strbuf_release()` calls as
well.

Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Martin Ågren
2017-10-01 19:42:08 +02:00
committed by Junio C Hamano
parent 4010f1d1b7
commit 886e1084d7
5 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
builtin/tag.c
View File

@ -552,9 +552,10 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
if (force && !is_null_oid(&prev) && oidcmp(&prev, &object))
printf(_("Updated tag '%s' (was %s)\n"), tag, find_unique_abbrev(prev.hash, DEFAULT_ABBREV));
strbuf_release(&err);
strbuf_release(&buf);
strbuf_release(&ref);
strbuf_release(&reflog_msg);
UNLEAK(buf);
UNLEAK(ref);
UNLEAK(reflog_msg);
UNLEAK(msg);
UNLEAK(err);
return 0;
}