mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'ma/bash-completion-leaking-x' into maint

Browse Source 
The completion script (in contrib/) contaminated global namespace
and clobbered on a shell variable $x.

* ma/bash-completion-leaking-x:
  completion: fix global bash variable leak on __gitcompappend
This commit is contained in:
Junio C Hamano
2015-04-27 12:23:51 -07:00
parent 631f6f1d47 852ff1c362
commit 89ba311df3
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/completion/git-completion.bash
View File

@ -186,7 +186,7 @@ fi
__gitcompappend () __gitcompappend ()
{ {
local i=${#COMPREPLY[@]} local x i=${#COMPREPLY[@]}
for x in $1; do for x in $1; do
if [[ "$x" == "$3"* ]]; then if [[ "$x" == "$3"* ]]; then
COMPREPLY[i++]="$2$x$4" COMPREPLY[i++]="$2$x$4"