git-gui: Move on to the next filename after staging/unstaging a change
Suppose the "Unstaged Changes" pane contains a list of files, and one of them is selected (i.e., that diff is currently being displayed). If one clicks on the icon to stage the change, git-gui clears the diff and one has to click on another filename to see the next diff in the list. This patch changes that behaviour. If one clicks on the icon to stage (or unstage) the file whose diff is being displayed, git-gui will move on to the next filename in the list and display that diff instead of a blank diff pane. If the selected file was at the end of the list, the diff pane will display the previous diff instead; if the selected file was the only one listed, the diff pane will become blank. If no diff is currently being displayed, this patch changes nothing. Signed-off-by: Abhijit Menon-Sen <ams@toroid.org> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
This commit is contained in:
		
				
					committed by
					
						
						Shawn O. Pearce
					
				
			
			
				
	
			
			
			
						parent
						
							95dcfa3633
						
					
				
				
					commit
					8a965b8ee2
				
			
							
								
								
									
										27
									
								
								git-gui.sh
									
									
									
									
									
								
							
							
						
						
									
										27
									
								
								git-gui.sh
									
									
									
									
									
								
							@ -1774,6 +1774,11 @@ proc do_commit {} {
 | 
			
		||||
	commit_tree
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
proc next_diff {} {
 | 
			
		||||
	global next_diff_p next_diff_w next_diff_i
 | 
			
		||||
	show_diff $next_diff_p $next_diff_w $next_diff_i
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
proc toggle_or_diff {w x y} {
 | 
			
		||||
	global file_states file_lists current_diff_path ui_index ui_workdir
 | 
			
		||||
	global last_clicked selected_paths
 | 
			
		||||
@ -1793,11 +1798,31 @@ proc toggle_or_diff {w x y} {
 | 
			
		||||
	$ui_workdir tag remove in_sel 0.0 end
 | 
			
		||||
 | 
			
		||||
	if {$col == 0} {
 | 
			
		||||
		if {$current_diff_path eq $path} {
 | 
			
		||||
		set i [expr {$lno-1}]
 | 
			
		||||
		set ll [expr {[llength $file_lists($w)]-1}]
 | 
			
		||||
 | 
			
		||||
		if {$i == $ll && $i == 0} {
 | 
			
		||||
			set after {reshow_diff;}
 | 
			
		||||
		} else {
 | 
			
		||||
			global next_diff_p next_diff_w next_diff_i
 | 
			
		||||
 | 
			
		||||
			if {$i < $ll} {
 | 
			
		||||
				set i [expr {$i + 1}]
 | 
			
		||||
			} else {
 | 
			
		||||
				set i [expr {$i - 1}]
 | 
			
		||||
			}
 | 
			
		||||
 | 
			
		||||
			set next_diff_i $i
 | 
			
		||||
			set next_diff_w $w
 | 
			
		||||
			set next_diff_p [lindex $file_lists($w) $i]
 | 
			
		||||
 | 
			
		||||
			if {$next_diff_p ne {} && $current_diff_path ne {}} {
 | 
			
		||||
				set after {next_diff;}
 | 
			
		||||
			} else {
 | 
			
		||||
				set after {}
 | 
			
		||||
			}
 | 
			
		||||
		}
 | 
			
		||||
 | 
			
		||||
		if {$w eq $ui_index} {
 | 
			
		||||
			update_indexinfo \
 | 
			
		||||
				"Unstaging [short_path $path] from commit" \
 | 
			
		||||
 | 
			
		||||
		Reference in New Issue
	
	Block a user