mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'ps/bisect-double-free-fix'

Browse Source 
Work around Coverity warning that would not trigger in practice.

* ps/bisect-double-free-fix:
  bisect: address Coverity warning about potential double free
This commit is contained in:
Junio C Hamano
2024-12-04 10:14:46 +09:00
parent e5b71577a6 5f9f7fafb7
commit 8c917be5d2
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bisect.c
View File

@ -442,8 +442,6 @@ void find_bisection(struct commit_list **commit_list, int *reaches,
best->next = NULL; best->next = NULL;
} }
*reaches = weight(best); *reaches = weight(best);
} else {
free_commit_list(*commit_list);
} }
*commit_list = best; *commit_list = best;

5
t/t6002-rev-list-bisect.sh
View File

@ -308,4 +308,9 @@ test_expect_success '--bisect-all --first-parent' '
test_cmp expect actual test_cmp expect actual
' '
test_expect_success '--bisect without any revisions' '
git rev-list --bisect HEAD..HEAD >out &&
test_must_be_empty out
'
test_done test_done