assert PARSE_OPT_NONEG in parse-options callbacks
In the spirit of517fe807d6
(assert NOARG/NONEG behavior of parse-options callbacks, 2018-11-05), let's cover some parse-options callbacks which expect to be used with PARSE_OPT_NONEG but don't explicitly assert that this is the case. These callbacks are all used correctly in the current code, but this will help document their expectations and future-proof the code. As a bonus, it also silences -Wunused-parameters (these were added since the initial sweep of517fe807d6
, and we can't yet turn on -Wunused-parameters to remind people because it has too many existing false positives). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
424e28fcad
commit
8d2aa8dfac
@ -105,6 +105,8 @@ int parse_opt_commit(const struct option *opt, const char *arg, int unset)
|
||||
struct commit *commit;
|
||||
struct commit **target = opt->value;
|
||||
|
||||
BUG_ON_OPT_NEG(unset);
|
||||
|
||||
if (!arg)
|
||||
return -1;
|
||||
if (get_oid(arg, &oid))
|
||||
|
Reference in New Issue
Block a user