mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

commit: restore --edit when combined with --fixup

Browse Source 
Recent changes to --fixup, adding amend suboption, caused the
--edit flag to be ignored as use_editor was always set to zero.

Restore edit_flag having higher priority than fixup_message when
deciding the value of use_editor by moving the edit flag condition
later in the method.

Signed-off-by: Joel Klinghed <the_jk@spawned.biz>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Joel Klinghed
2021-08-14 21:40:30 +00:00
committed by Junio C Hamano
parent 5d213e46bb
commit 8ef6aad664
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
builtin/commit.c
View File

@ -1253,8 +1253,6 @@ static int parse_and_validate_options(int argc, const char *argv[],
if (logfile || have_option_m || use_message) if (logfile || have_option_m || use_message)
use_editor = 0; use_editor = 0;
if (0 <= edit_flag)
use_editor = edit_flag;
/* Sanity check options */ /* Sanity check options */
if (amend && !current_head) if (amend && !current_head)
@ -1344,6 +1342,9 @@ static int parse_and_validate_options(int argc, const char *argv[],
} }
} }
if (0 <= edit_flag)
use_editor = edit_flag;
cleanup_mode = get_cleanup_mode(cleanup_arg, use_editor); cleanup_mode = get_cleanup_mode(cleanup_arg, use_editor);
handle_untracked_files_arg(s); handle_untracked_files_arg(s);

9
t/t7500-commit-template-squash-signoff.sh
View File

@ -270,7 +270,7 @@ EOF
test_expect_success 'commit --fixup provides correct one-line commit message' ' test_expect_success 'commit --fixup provides correct one-line commit message' '
commit_for_rebase_autosquash_setup && commit_for_rebase_autosquash_setup &&
git commit --fixup HEAD~1 && EDITOR="echo ignored >>" git commit --fixup HEAD~1 &&
commit_msg_is "fixup! target message subject line" commit_msg_is "fixup! target message subject line"
' '
@ -281,6 +281,13 @@ test_expect_success 'commit --fixup -m"something" -m"extra"' '
extra" extra"
' '
test_expect_success 'commit --fixup --edit' '
commit_for_rebase_autosquash_setup &&
EDITOR="printf \"something\nextra\" >>" git commit --fixup HEAD~1 --edit &&
commit_msg_is "fixup! target message subject linesomething
extra"
'
get_commit_msg () { get_commit_msg () {
rev="$1" && rev="$1" &&
git log -1 --pretty=format:"%B" "$rev" git log -1 --pretty=format:"%B" "$rev"