mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

convert "oidcmp() != 0" to "!oideq()"

Browse Source 
This is the flip side of the previous two patches: checking
for a non-zero oidcmp() can be more strictly expressed as
inequality. Like those patches, we write "!= 0" in the
coccinelle transformation, which covers by isomorphism the
more common:

  if (oidcmp(E1, E2))

As with the previous two patches, this patch can be achieved
almost entirely by running "make coccicheck"; the only
differences are manual line-wrap fixes to match the original
code.

There is one thing to note for anybody replicating this,
though: coccinelle 1.0.4 seems to miss the case in
builtin/tag.c, even though it's basically the same as all
the others. Running with 1.0.7 does catch this, so
presumably it's just a coccinelle bug that was fixed in the
interim.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2018-08-28 17:22:48 -04:00
committed by Junio C Hamano
parent e3ff0683e2
commit 9001dc2a74
31 changed files with 55 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bisect.c
View File

@ -595,7 +595,7 @@ static struct commit_list *skip_away(struct commit_list *list, int count)
for (i = 0; cur; cur = cur->next, i++) {
if (i == index) {
if (oidcmp(&cur->item->object.oid, current_bad_oid))
if (!oideq(&cur->item->object.oid, current_bad_oid))
return cur;
if (previous)
return previous;