convert "oidcmp() != 0" to "!oideq()"
This is the flip side of the previous two patches: checking for a non-zero oidcmp() can be more strictly expressed as inequality. Like those patches, we write "!= 0" in the coccinelle transformation, which covers by isomorphism the more common: if (oidcmp(E1, E2)) As with the previous two patches, this patch can be achieved almost entirely by running "make coccicheck"; the only differences are manual line-wrap fixes to match the original code. There is one thing to note for anybody replicating this, though: coccinelle 1.0.4 seems to miss the case in builtin/tag.c, even though it's basically the same as all the others. Running with 1.0.7 does catch this, so presumably it's just a coccinelle bug that was fixed in the interim. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
e3ff0683e2
commit
9001dc2a74
@ -180,7 +180,7 @@ static int check_local_mod(struct object_id *head, int index_only)
|
||||
if (no_head
|
||||
|| get_tree_entry(head, name, &oid, &mode)
|
||||
|| ce->ce_mode != create_ce_mode(mode)
|
||||
|| oidcmp(&ce->oid, &oid))
|
||||
|| !oideq(&ce->oid, &oid))
|
||||
staged_changes = 1;
|
||||
|
||||
/*
|
||||
|
||||
Reference in New Issue
Block a user