use new wrapper write_file() for simple file writing
This fixes common problems in these code about error handling, forgetting to close the file handle after fprintf() fails, or not printing out the error string.. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
316e53e68c
commit
91aacda85a
@ -342,7 +342,6 @@ int set_git_dir_init(const char *git_dir, const char *real_git_dir,
|
||||
static void separate_git_dir(const char *git_dir)
|
||||
{
|
||||
struct stat st;
|
||||
FILE *fp;
|
||||
|
||||
if (!stat(git_link, &st)) {
|
||||
const char *src;
|
||||
@ -358,11 +357,7 @@ static void separate_git_dir(const char *git_dir)
|
||||
die_errno(_("unable to move %s to %s"), src, git_dir);
|
||||
}
|
||||
|
||||
fp = fopen(git_link, "w");
|
||||
if (!fp)
|
||||
die(_("Could not create git link %s"), git_link);
|
||||
fprintf(fp, "gitdir: %s\n", git_dir);
|
||||
fclose(fp);
|
||||
write_file(git_link, 1, "gitdir: %s\n", git_dir);
|
||||
}
|
||||
|
||||
int init_db(const char *template_dir, unsigned int flags)
|
||||
|
||||
Reference in New Issue
Block a user