mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remote.c: turn some error() or die() to BUG()

Browse Source 
The first error, "internal error", is clearly a BUG(). The second two
are meant to catch calls with invalid parameters and should never
happen outside the test suite.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Nguyễn Thái Ngọc Duy
2018-11-10 06:16:08 +01:00
committed by Junio C Hamano
parent dd509db342
commit 92ca868068
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
remote.c
View File

@ -620,7 +620,7 @@ static void handle_duplicate(struct ref *ref1, struct ref *ref2)
* FETCH_HEAD_IGNORE entries always appear at * FETCH_HEAD_IGNORE entries always appear at
* the end of the list. * the end of the list.
*/ */
die(_("Internal error")); BUG("Internal error");
} }
} }
free(ref2->peer_ref); free(ref2->peer_ref);
@ -707,7 +707,7 @@ static void query_refspecs_multiple(struct refspec *rs,
int find_src = !query->src; int find_src = !query->src;
if (find_src && !query->dst) if (find_src && !query->dst)
error("query_refspecs_multiple: need either src or dst"); BUG("query_refspecs_multiple: need either src or dst");
for (i = 0; i < rs->nr; i++) { for (i = 0; i < rs->nr; i++) {
struct refspec_item *refspec = &rs->items[i]; struct refspec_item *refspec = &rs->items[i];
@ -735,7 +735,7 @@ int query_refspecs(struct refspec *rs, struct refspec_item *query)
char **result = find_src ? &query->src : &query->dst; char **result = find_src ? &query->src : &query->dst;
if (find_src && !query->dst) if (find_src && !query->dst)
return error("query_refspecs: need either src or dst"); BUG("query_refspecs: need either src or dst");
for (i = 0; i < rs->nr; i++) { for (i = 0; i < rs->nr; i++) {
struct refspec_item *refspec = &rs->items[i]; struct refspec_item *refspec = &rs->items[i];