Convert resolve_ref+xstrdup to new resolve_refdup function
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
e4776bd936
commit
96ec7b1e70
@ -804,6 +804,7 @@ static int merge_commit(struct notes_merge_options *o)
|
||||
struct notes_tree *t;
|
||||
struct commit *partial;
|
||||
struct pretty_print_context pretty_ctx;
|
||||
void *local_ref_to_free;
|
||||
int ret;
|
||||
|
||||
/*
|
||||
@ -826,10 +827,10 @@ static int merge_commit(struct notes_merge_options *o)
|
||||
t = xcalloc(1, sizeof(struct notes_tree));
|
||||
init_notes(t, "NOTES_MERGE_PARTIAL", combine_notes_overwrite, 0);
|
||||
|
||||
o->local_ref = resolve_ref("NOTES_MERGE_REF", sha1, 0, NULL);
|
||||
o->local_ref = local_ref_to_free =
|
||||
resolve_refdup("NOTES_MERGE_REF", sha1, 0, NULL);
|
||||
if (!o->local_ref)
|
||||
die("Failed to resolve NOTES_MERGE_REF");
|
||||
o->local_ref = xstrdup(o->local_ref);
|
||||
|
||||
if (notes_merge_commit(o, t, partial, sha1))
|
||||
die("Failed to finalize notes merge");
|
||||
@ -846,7 +847,7 @@ static int merge_commit(struct notes_merge_options *o)
|
||||
free_notes(t);
|
||||
strbuf_release(&msg);
|
||||
ret = merge_abort(o);
|
||||
free((char *)o->local_ref);
|
||||
free(local_ref_to_free);
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user