rev-parse: fix segfault with missing --path-format argument
Calling "git rev-parse --path-format" without an argument segfaults
instead of giving an error message. Commit fac60b8925
(rev-parse: add
option for absolute or relative path formatting, 2020-12-13) added the
argument parsing code but forgot to handle NULL.
Returning an error makes sense here because there is no default value we
could use. Add a test case to verify.
Signed-off-by: Wolfgang Müller <wolf@oriole.systems>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
48bf2fa8ba
commit
99fc555188
@ -759,6 +759,8 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix)
|
||||
continue;
|
||||
}
|
||||
if (opt_with_value(arg, "--path-format", &arg)) {
|
||||
if (!arg)
|
||||
die("--path-format requires an argument");
|
||||
if (!strcmp(arg, "absolute")) {
|
||||
format = FORMAT_CANONICAL;
|
||||
} else if (!strcmp(arg, "relative")) {
|
||||
|
Reference in New Issue
Block a user