refs: stop modifying global log_all_ref_updates
variable
In refs-related code we modify the global `log_all_ref_updates` variable, which is done because `should_autocreate_reflog()` does not accept passing an `enum log_refs_config` but instead accesses the global variable. Adapt its interface such that the value is provided by the caller, which allows us to compute the proper value locally without having to modify global state. This change requires us to move the enum to "repo-settings.h", or otherwise we get compilation errors due to include cycles. We're about to fully move this setting into the repo-settings subsystem anyway, so this is fine. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
118fd1a26d
commit
9a20b889e8
@ -16,6 +16,13 @@ enum fetch_negotiation_setting {
|
||||
FETCH_NEGOTIATION_NOOP,
|
||||
};
|
||||
|
||||
enum log_refs_config {
|
||||
LOG_REFS_UNSET = -1,
|
||||
LOG_REFS_NONE = 0,
|
||||
LOG_REFS_NORMAL,
|
||||
LOG_REFS_ALWAYS
|
||||
};
|
||||
|
||||
struct repo_settings {
|
||||
int initialized;
|
||||
|
||||
|
Reference in New Issue
Block a user