mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ref-filter.c: rename 'ref_filter_handler()' to 'filter_one()'

Browse Source 
Rename 'ref_filter_handler()' to 'filter_one()' to more clearly distinguish
it from other ref filtering callbacks that will be added in later patches.
The "*_one()" naming convention is common throughout the codebase for
iteration callbacks.

Signed-off-by: Victoria Dye <vdye@github.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Victoria Dye
2023-11-14 19:53:53 +00:00
committed by Junio C Hamano
parent e7574b0c6b
commit 9c575b0202
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ref-filter.c
View File

@ -2686,7 +2686,7 @@ struct ref_filter_cbdata {
* A call-back given to for_each_ref(). Filter refs and keep them for * A call-back given to for_each_ref(). Filter refs and keep them for
* later object processing. * later object processing.
*/ */
static int ref_filter_handler(const char *refname, const struct object_id *oid, int flag, void *cb_data) static int filter_one(const char *refname, const struct object_id *oid, int flag, void *cb_data)
{ {
struct ref_filter_cbdata *ref_cbdata = cb_data; struct ref_filter_cbdata *ref_cbdata = cb_data;
struct ref_filter *filter = ref_cbdata->filter; struct ref_filter *filter = ref_cbdata->filter;
@ -2917,15 +2917,15 @@ int filter_refs(struct ref_array *array, struct ref_filter *filter, unsigned int
* of filter_ref_kind(). * of filter_ref_kind().
*/ */
if (filter->kind == FILTER_REFS_BRANCHES) if (filter->kind == FILTER_REFS_BRANCHES)
ret = for_each_fullref_in("refs/heads/", ref_filter_handler, &ref_cbdata); ret = for_each_fullref_in("refs/heads/", filter_one, &ref_cbdata);
else if (filter->kind == FILTER_REFS_REMOTES) else if (filter->kind == FILTER_REFS_REMOTES)
ret = for_each_fullref_in("refs/remotes/", ref_filter_handler, &ref_cbdata); ret = for_each_fullref_in("refs/remotes/", filter_one, &ref_cbdata);
else if (filter->kind == FILTER_REFS_TAGS) else if (filter->kind == FILTER_REFS_TAGS)
ret = for_each_fullref_in("refs/tags/", ref_filter_handler, &ref_cbdata); ret = for_each_fullref_in("refs/tags/", filter_one, &ref_cbdata);
else if (filter->kind & FILTER_REFS_ALL) else if (filter->kind & FILTER_REFS_ALL)
ret = for_each_fullref_in_pattern(filter, ref_filter_handler, &ref_cbdata); ret = for_each_fullref_in_pattern(filter, filter_one, &ref_cbdata);
if (!ret && (filter->kind & FILTER_REFS_DETACHED_HEAD)) if (!ret && (filter->kind & FILTER_REFS_DETACHED_HEAD))
head_ref(ref_filter_handler, &ref_cbdata); head_ref(filter_one, &ref_cbdata);
} }
clear_contains_cache(&filter->internal.contains_cache); clear_contains_cache(&filter->internal.contains_cache);