mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

builtin/send-pack: fix leaking refspecs

Browse Source 
We never free data associated with the assembled refspec in
git-send-pack(1), causing a memory leak. Fix this.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt
2024-08-22 11:17:46 +02:00
committed by Junio C Hamano
parent ca52234183
commit a09efb74e3
6 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
builtin/send-pack.c
View File

@ -338,5 +338,6 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)
free_refs(remote_refs); free_refs(remote_refs);
free_refs(local_refs); free_refs(local_refs);
refspec_clear(&rs);
return ret; return ret;
} }

1
t/t5400-send-pack.sh
View File

@ -9,6 +9,7 @@ test_description='See why rewinding head breaks send-pack
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
cnt=64 cnt=64

2
t/t5401-update-hooks.sh
View File

@ -4,6 +4,8 @@
# #
test_description='Test the update hook infrastructure.' test_description='Test the update hook infrastructure.'
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
test_expect_success setup ' test_expect_success setup '

2
t/t5408-send-pack-stdin.sh
View File

@ -1,6 +1,8 @@
#!/bin/sh #!/bin/sh
test_description='send-pack --stdin tests' test_description='send-pack --stdin tests'
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
create_ref () { create_ref () {

1
t/t5548-push-porcelain.sh
View File

@ -4,6 +4,7 @@
# #
test_description='Test git push porcelain output' test_description='Test git push porcelain output'
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
# Create commits in <repo> and assign each commit's oid to shell variables # Create commits in <repo> and assign each commit's oid to shell variables

2
t/t5812-proto-disable-http.sh
View File

@ -1,6 +1,8 @@
#!/bin/sh #!/bin/sh
test_description='test disabling of git-over-http in clone/fetch' test_description='test disabling of git-over-http in clone/fetch'
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
. "$TEST_DIRECTORY/lib-proto-disable.sh" . "$TEST_DIRECTORY/lib-proto-disable.sh"
. "$TEST_DIRECTORY/lib-httpd.sh" . "$TEST_DIRECTORY/lib-httpd.sh"