mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'jn/clean-use-error-not-fprintf-on-stderr'

Browse Source 
Some error messages in "git config" were emitted without calling
the usual error() facility.

* jn/clean-use-error-not-fprintf-on-stderr:
  config: use error() instead of fprintf(stderr, ...)
This commit is contained in:
Junio C Hamano
2015-05-11 14:23:52 -07:00
parent 5fa9e4c4f1 95d621217a
commit a0c0c2e5c2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
builtin/config.c
View File

@ -193,7 +193,7 @@ static int get_value(const char *key_, const char *regex_)
key_regexp = (regex_t*)xmalloc(sizeof(regex_t)); key_regexp = (regex_t*)xmalloc(sizeof(regex_t));
if (regcomp(key_regexp, key, REG_EXTENDED)) { if (regcomp(key_regexp, key, REG_EXTENDED)) {
fprintf(stderr, "Invalid key pattern: %s\n", key_); error("invalid key pattern: %s", key_);
free(key_regexp); free(key_regexp);
key_regexp = NULL; key_regexp = NULL;
ret = CONFIG_INVALID_PATTERN; ret = CONFIG_INVALID_PATTERN;
@ -214,7 +214,7 @@ static int get_value(const char *key_, const char *regex_)
regexp = (regex_t*)xmalloc(sizeof(regex_t)); regexp = (regex_t*)xmalloc(sizeof(regex_t));
if (regcomp(regexp, regex_, REG_EXTENDED)) { if (regcomp(regexp, regex_, REG_EXTENDED)) {
fprintf(stderr, "Invalid pattern: %s\n", regex_); error("invalid pattern: %s", regex_);
free(regexp); free(regexp);
regexp = NULL; regexp = NULL;
ret = CONFIG_INVALID_PATTERN; ret = CONFIG_INVALID_PATTERN;