Merge branch 'mv/merge-custom'
* mv/merge-custom: t7606: fix custom merge test Fix "git-merge -s bogo" help text Update .gitignore to ignore git-help Builtin git-help. builtin-help: always load_command_list() in cmd_help() Add a second testcase for handling invalid strategies in git-merge Add a new test for using a custom merge strategy builtin-merge: allow using a custom strategy builtin-help: make some internal functions available to other builtins Conflicts: help.c
This commit is contained in:
@ -22,6 +22,7 @@
|
||||
#include "log-tree.h"
|
||||
#include "color.h"
|
||||
#include "rerere.h"
|
||||
#include "help.h"
|
||||
|
||||
#define DEFAULT_TWOHEAD (1<<0)
|
||||
#define DEFAULT_OCTOPUS (1<<1)
|
||||
@ -77,7 +78,9 @@ static int option_parse_message(const struct option *opt,
|
||||
static struct strategy *get_strategy(const char *name)
|
||||
{
|
||||
int i;
|
||||
struct strbuf err;
|
||||
struct strategy *ret;
|
||||
static struct cmdnames main_cmds, other_cmds;
|
||||
static int longest;
|
||||
|
||||
if (!name)
|
||||
return NULL;
|
||||
@ -86,12 +89,45 @@ static struct strategy *get_strategy(const char *name)
|
||||
if (!strcmp(name, all_strategy[i].name))
|
||||
return &all_strategy[i];
|
||||
|
||||
strbuf_init(&err, 0);
|
||||
for (i = 0; i < ARRAY_SIZE(all_strategy); i++)
|
||||
strbuf_addf(&err, " %s", all_strategy[i].name);
|
||||
fprintf(stderr, "Could not find merge strategy '%s'.\n", name);
|
||||
fprintf(stderr, "Available strategies are:%s.\n", err.buf);
|
||||
exit(1);
|
||||
if (!longest) {
|
||||
struct cmdnames not_strategies;
|
||||
|
||||
memset(&main_cmds, 0, sizeof(struct cmdnames));
|
||||
memset(&other_cmds, 0, sizeof(struct cmdnames));
|
||||
memset(¬_strategies, 0, sizeof(struct cmdnames));
|
||||
longest = load_command_list("git-merge-", &main_cmds,
|
||||
&other_cmds);
|
||||
for (i = 0; i < main_cmds.cnt; i++) {
|
||||
int j, found = 0;
|
||||
struct cmdname *ent = main_cmds.names[i];
|
||||
for (j = 0; j < ARRAY_SIZE(all_strategy); j++)
|
||||
if (!strncmp(ent->name, all_strategy[j].name, ent->len)
|
||||
&& !all_strategy[j].name[ent->len])
|
||||
found = 1;
|
||||
if (!found)
|
||||
add_cmdname(¬_strategies, ent->name, ent->len);
|
||||
exclude_cmds(&main_cmds, ¬_strategies);
|
||||
}
|
||||
}
|
||||
if (!is_in_cmdlist(&main_cmds, name) && !is_in_cmdlist(&other_cmds, name)) {
|
||||
fprintf(stderr, "Could not find merge strategy '%s'.\n", name);
|
||||
fprintf(stderr, "Available strategies are:");
|
||||
for (i = 0; i < main_cmds.cnt; i++)
|
||||
fprintf(stderr, " %s", main_cmds.names[i]->name);
|
||||
fprintf(stderr, ".\n");
|
||||
if (other_cmds.cnt) {
|
||||
fprintf(stderr, "Available custom strategies are:");
|
||||
for (i = 0; i < other_cmds.cnt; i++)
|
||||
fprintf(stderr, " %s", other_cmds.names[i]->name);
|
||||
fprintf(stderr, ".\n");
|
||||
}
|
||||
exit(1);
|
||||
}
|
||||
|
||||
ret = xmalloc(sizeof(struct strategy));
|
||||
memset(ret, 0, sizeof(struct strategy));
|
||||
ret->name = xstrdup(name);
|
||||
return ret;
|
||||
}
|
||||
|
||||
static void append_strategy(struct strategy *s)
|
||||
|
||||
Reference in New Issue
Block a user