mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refs: add index field to struct ref_udpate

Browse Source 
The reftable backend, sorts its updates by refname before applying them,
this ensures that the references are stored sorted. When migrating
reflogs from one backend to another, the order of the reflogs must be
maintained. Add a new `index` field to the `ref_update` struct to
facilitate this.

This field is used in the reftable backend's sort comparison function
`transaction_update_cmp`, to ensure that indexed fields maintain their
order.

Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Karthik Nayak
2024-12-16 17:44:27 +01:00
committed by Junio C Hamano
parent 1a83e26d72
commit a3582e2eac
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
refs/reftable-backend.c
View File

@ -1279,8 +1279,17 @@ static int reftable_be_transaction_abort(struct ref_store *ref_store UNUSED,
static int transaction_update_cmp(const void *a, const void *b)
{
return strcmp(((struct reftable_transaction_update *)a)->update->refname,
((struct reftable_transaction_update *)b)->update->refname);
struct reftable_transaction_update *update_a = (struct reftable_transaction_update *)a;
struct reftable_transaction_update *update_b = (struct reftable_transaction_update *)b;
/*
* If there is an index set, it should take preference (default is 0).
* This ensures that updates with indexes are sorted amongst themselves.
*/
if (update_a->update->index || update_b->update->index)
return update_a->update->index - update_b->update->index;
return strcmp(update_a->update->refname, update_b->update->refname);
}
static int write_transaction_table(struct reftable_writer *writer, void *cb_data)