git-gc: always use -A when manually repacking
Now that repack -A will leave unreferenced objects unpacked, there is no reason to use the -a option to repack (which will discard unreferenced objects). The unpacked unreferenced objects will not be repacked by a subsequent repack, and will eventually be pruned by git-gc based on the gc.pruneExpire config option.
This commit is contained in:

committed by
Junio C Hamano

parent
ccc1297226
commit
a37cce3b23
13
builtin-gc.c
13
builtin-gc.c
@ -256,17 +256,8 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
|
|||||||
"performance. You may also\n"
|
"performance. You may also\n"
|
||||||
"run \"git gc\" manually. See "
|
"run \"git gc\" manually. See "
|
||||||
"\"git help gc\" for more information.\n");
|
"\"git help gc\" for more information.\n");
|
||||||
} else {
|
} else
|
||||||
/*
|
append_option(argv_repack, "-A", MAX_ADD);
|
||||||
* Use safer (for shared repos) "-A" option to
|
|
||||||
* repack when not pruning. Auto-gc makes its
|
|
||||||
* own decision.
|
|
||||||
*/
|
|
||||||
if (prune)
|
|
||||||
append_option(argv_repack, "-a", MAX_ADD);
|
|
||||||
else
|
|
||||||
append_option(argv_repack, "-A", MAX_ADD);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (pack_refs && run_command_v_opt(argv_pack_refs, RUN_GIT_CMD))
|
if (pack_refs && run_command_v_opt(argv_pack_refs, RUN_GIT_CMD))
|
||||||
return error(FAILED_RUN, argv_pack_refs[0]);
|
return error(FAILED_RUN, argv_pack_refs[0]);
|
||||||
|
Reference in New Issue
Block a user