tests: add missing &&
Breaks in a test assertion's && chain can potentially hide failures from earlier commands in the chain. Commands intended to fail should be marked with !, test_must_fail, or test_might_fail. The examples in this patch do not require that. Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
00648ba050
commit
a48fcd8369
@ -41,11 +41,11 @@ test_expect_success 'setup' "
|
||||
"
|
||||
|
||||
test_expect_success 'stat binary diff -- should not fail.' \
|
||||
'git checkout master
|
||||
'git checkout master &&
|
||||
git apply --stat --summary B.diff'
|
||||
|
||||
test_expect_success 'stat binary diff (copy) -- should not fail.' \
|
||||
'git checkout master
|
||||
'git checkout master &&
|
||||
git apply --stat --summary C.diff'
|
||||
|
||||
test_expect_success 'check binary diff -- should fail.' \
|
||||
@ -69,11 +69,11 @@ test_expect_success \
|
||||
'
|
||||
|
||||
test_expect_success 'check binary diff with replacement.' \
|
||||
'git checkout master
|
||||
'git checkout master &&
|
||||
git apply --check --allow-binary-replacement BF.diff'
|
||||
|
||||
test_expect_success 'check binary diff with replacement (copy).' \
|
||||
'git checkout master
|
||||
'git checkout master &&
|
||||
git apply --check --allow-binary-replacement CF.diff'
|
||||
|
||||
# Now we start applying them.
|
||||
|
Reference in New Issue
Block a user