test: avoid pipes in git related commands for test
Avoid using pipes downstream of Git commands since the exit codes of commands upstream of pipes get swallowed, thus potentially hiding failure of those commands. Instead, capture Git command output to a file and apply the downstream command(s) to that file. Signed-off-by: Pratik Karki <predatoramigo@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
d32eb83c1d
commit
a4d4e32a70
@ -21,37 +21,37 @@ uuid=161ce429-a9dd-4828-af4a-52023f968c89
|
||||
|
||||
bar_url=http://mayonaise/svnrepo/bar
|
||||
test_expect_success 'verify metadata for /bar' "
|
||||
git cat-file commit refs/remotes/bar | \
|
||||
grep '^git-svn-id: $bar_url@12 $uuid$' &&
|
||||
git cat-file commit refs/remotes/bar~1 | \
|
||||
grep '^git-svn-id: $bar_url@11 $uuid$' &&
|
||||
git cat-file commit refs/remotes/bar~2 | \
|
||||
grep '^git-svn-id: $bar_url@10 $uuid$' &&
|
||||
git cat-file commit refs/remotes/bar~3 | \
|
||||
grep '^git-svn-id: $bar_url@9 $uuid$' &&
|
||||
git cat-file commit refs/remotes/bar~4 | \
|
||||
grep '^git-svn-id: $bar_url@6 $uuid$' &&
|
||||
git cat-file commit refs/remotes/bar~5 | \
|
||||
grep '^git-svn-id: $bar_url@1 $uuid$'
|
||||
git cat-file commit refs/remotes/bar >actual &&
|
||||
grep '^git-svn-id: $bar_url@12 $uuid$' actual &&
|
||||
git cat-file commit refs/remotes/bar~1 >actual &&
|
||||
grep '^git-svn-id: $bar_url@11 $uuid$' actual &&
|
||||
git cat-file commit refs/remotes/bar~2 >actual &&
|
||||
grep '^git-svn-id: $bar_url@10 $uuid$' actual &&
|
||||
git cat-file commit refs/remotes/bar~3 >actual &&
|
||||
grep '^git-svn-id: $bar_url@9 $uuid$' actual &&
|
||||
git cat-file commit refs/remotes/bar~4 >actual &&
|
||||
grep '^git-svn-id: $bar_url@6 $uuid$' actual &&
|
||||
git cat-file commit refs/remotes/bar~5 >actual &&
|
||||
grep '^git-svn-id: $bar_url@1 $uuid$' actual
|
||||
"
|
||||
|
||||
e_url=http://mayonaise/svnrepo/dir/a/b/c/d/e
|
||||
test_expect_success 'verify metadata for /dir/a/b/c/d/e' "
|
||||
git cat-file commit refs/remotes/e | \
|
||||
grep '^git-svn-id: $e_url@1 $uuid$'
|
||||
git cat-file commit refs/remotes/e >actual &&
|
||||
grep '^git-svn-id: $e_url@1 $uuid$' actual
|
||||
"
|
||||
|
||||
dir_url=http://mayonaise/svnrepo/dir
|
||||
test_expect_success 'verify metadata for /dir' "
|
||||
git cat-file commit refs/remotes/dir | \
|
||||
grep '^git-svn-id: $dir_url@2 $uuid$' &&
|
||||
git cat-file commit refs/remotes/dir~1 | \
|
||||
grep '^git-svn-id: $dir_url@1 $uuid$'
|
||||
git cat-file commit refs/remotes/dir >actual &&
|
||||
grep '^git-svn-id: $dir_url@2 $uuid$' actual &&
|
||||
git cat-file commit refs/remotes/dir~1 >actual &&
|
||||
grep '^git-svn-id: $dir_url@1 $uuid$' actual
|
||||
"
|
||||
|
||||
test_expect_success 'find commit based on SVN revision number' "
|
||||
git svn find-rev r12 |
|
||||
grep $(git rev-parse HEAD)
|
||||
git svn find-rev r12 >actual &&
|
||||
grep $(git rev-parse HEAD) actual
|
||||
"
|
||||
|
||||
test_expect_success 'empty rebase' "
|
||||
|
Reference in New Issue
Block a user