t1300: extract and use test_cmp_config()
In many config-related tests it's common to check if a config variable has expected value and we want to print the differences when the test fails. Doing it the normal way is three lines of shell code. Let's add a function do to all this (and a little more). This function has uses outside t1300 as well but I'm not going to convert them all. And it will be used in the next commit where per-worktree config feature is introduced. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
c4df23f792
commit
a5db0b77b9
@ -747,6 +747,29 @@ test_cmp() {
|
||||
$GIT_TEST_CMP "$@"
|
||||
}
|
||||
|
||||
# Check that the given config key has the expected value.
|
||||
#
|
||||
# test_cmp_config [-C <dir>] <expected-value>
|
||||
# [<git-config-options>...] <config-key>
|
||||
#
|
||||
# for example to check that the value of core.bar is foo
|
||||
#
|
||||
# test_cmp_config foo core.bar
|
||||
#
|
||||
test_cmp_config() {
|
||||
local GD &&
|
||||
if test "$1" = "-C"
|
||||
then
|
||||
shift &&
|
||||
GD="-C $1" &&
|
||||
shift
|
||||
fi &&
|
||||
printf "%s\n" "$1" >expect.config &&
|
||||
shift &&
|
||||
git $GD config "$@" >actual.config &&
|
||||
test_cmp expect.config actual.config
|
||||
}
|
||||
|
||||
# test_cmp_bin - helper to compare binary files
|
||||
|
||||
test_cmp_bin() {
|
||||
|
||||
Reference in New Issue
Block a user