Merge branch 'jk/unused-annotation'

Annotate function parameters that are not used (but cannot be
removed for structural reasons), to prepare us to later compile
with -Wunused warning turned on.

* jk/unused-annotation:
  is_path_owned_by_current_uid(): mark "report" parameter as unused
  run-command: mark unused async callback parameters
  mark unused read_tree_recursive() callback parameters
  hashmap: mark unused callback parameters
  config: mark unused callback parameters
  streaming: mark unused virtual method parameters
  transport: mark bundle transport_options as unused
  refs: mark unused virtual method parameters
  refs: mark unused reflog callback parameters
  refs: mark unused each_ref_fn parameters
  git-compat-util: add UNUSED macro
This commit is contained in:
Junio C Hamano
2022-09-14 12:56:38 -07:00
92 changed files with 337 additions and 234 deletions

View File

@ -176,8 +176,10 @@ static int rev_list_insert_ref(struct fetch_negotiator *negotiator,
return 0;
}
static int rev_list_insert_ref_oid(const char *refname, const struct object_id *oid,
int flag, void *cb_data)
static int rev_list_insert_ref_oid(const char *UNUSED(refname),
const struct object_id *oid,
int UNUSED(flag),
void *cb_data)
{
return rev_list_insert_ref(cb_data, oid);
}
@ -600,8 +602,10 @@ static int mark_complete(const struct object_id *oid)
return 0;
}
static int mark_complete_oid(const char *refname, const struct object_id *oid,
int flag, void *cb_data)
static int mark_complete_oid(const char *UNUSED(refname),
const struct object_id *oid,
int UNUSED(flag),
void *UNUSED(cb_data))
{
return mark_complete(oid);
}
@ -839,7 +843,7 @@ static int everything_local(struct fetch_pack_args *args,
return retval;
}
static int sideband_demux(int in, int out, void *data)
static int sideband_demux(int UNUSED(in), int out, void *data)
{
int *xd = data;
int ret;