Merge branch 'jk/unused-annotation'

Annotate function parameters that are not used (but cannot be
removed for structural reasons), to prepare us to later compile
with -Wunused warning turned on.

* jk/unused-annotation:
  is_path_owned_by_current_uid(): mark "report" parameter as unused
  run-command: mark unused async callback parameters
  mark unused read_tree_recursive() callback parameters
  hashmap: mark unused callback parameters
  config: mark unused callback parameters
  streaming: mark unused virtual method parameters
  transport: mark bundle transport_options as unused
  refs: mark unused virtual method parameters
  refs: mark unused reflog callback parameters
  refs: mark unused each_ref_fn parameters
  git-compat-util: add UNUSED macro
This commit is contained in:
Junio C Hamano
2022-09-14 12:56:38 -07:00
92 changed files with 337 additions and 234 deletions

View File

@ -1170,7 +1170,7 @@ static int mark_our_ref(const char *refname, const char *refname_full,
}
static int check_ref(const char *refname_full, const struct object_id *oid,
int flag, void *cb_data)
int UNUSED(flag), void *UNUSED(cb_data))
{
const char *refname = strip_namespace(refname_full);
@ -1194,7 +1194,7 @@ static void format_session_id(struct strbuf *buf, struct upload_pack_data *d) {
}
static int send_ref(const char *refname, const struct object_id *oid,
int flag, void *cb_data)
int UNUSED(flag), void *cb_data)
{
static const char *capabilities = "multi_ack thin-pack side-band"
" side-band-64k ofs-delta shallow deepen-since deepen-not"
@ -1236,7 +1236,8 @@ static int send_ref(const char *refname, const struct object_id *oid,
return 0;
}
static int find_symref(const char *refname, const struct object_id *oid,
static int find_symref(const char *refname,
const struct object_id *UNUSED(oid),
int flag, void *cb_data)
{
const char *symref_target;