mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t1300: don't create unused files

Browse Source 
Three tests in t1300-config.sh check that "git config --get" barfs when
syntax errors are present in the config file.  The tests redirect
standard output and standard error of "git config --get" to files,
"actual" and "error" correspondingly.  They assert presence of an error
message in file "error".  However, these tests don't use file "actual"
for assertions.

Don't redirect standard output of "git config --get" to file "actual" in
t1300-config.sh to avoid creating unnecessary files.

Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Andrei Rybak
2023-04-17 21:10:41 +02:00
committed by Junio C Hamano
parent 6fc68e7ca3
commit a7cae2905b
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
t/t1300-config.sh
View File

@ -1575,7 +1575,7 @@ test_expect_success 'barf on syntax error' '
[section]
key garbage
EOF
test_must_fail git config --get section.key >actual 2>error &&
test_must_fail git config --get section.key 2>error &&
test_i18ngrep " line 3 " error
'
@ -1585,7 +1585,7 @@ test_expect_success 'barf on incomplete section header' '
[section
key = value
EOF
test_must_fail git config --get section.key >actual 2>error &&
test_must_fail git config --get section.key 2>error &&
test_i18ngrep " line 2 " error
'
@ -1595,7 +1595,7 @@ test_expect_success 'barf on incomplete string' '
[section]
key = "value string
EOF
test_must_fail git config --get section.key >actual 2>error &&
test_must_fail git config --get section.key 2>error &&
test_i18ngrep " line 3 " error
'