bisect: Store first bad commit as comment in log file

When bisect successfully finds a single revision, the first bad commit
should be shown to human readers of 'git bisect log'.

This resolves the apparent disconnect between the bisection result and
the log when a bug reporter says "I know that the first bad commit is
$rev, as you can see from $(git bisect log)".

Signed-off-by: Torstein Hegge <hegge@resisty.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Torstein Hegge
2013-04-13 17:22:57 +02:00
committed by Junio C Hamano
parent 85e7e81ccf
commit a7f8b8ac94
2 changed files with 25 additions and 1 deletions

View File

@ -311,7 +311,13 @@ bisect_next() {
res=$?
# Check if we should exit because bisection is finished
test $res -eq 10 && exit 0
if test $res -eq 10
then
bad_rev=$(git show-ref --hash --verify refs/bisect/bad)
bad_commit=$(git show-branch $bad_rev)
echo "# first bad commit: $bad_commit" >>"$GIT_DIR/BISECT_LOG"
exit 0
fi
# Check for an error in the bisection process
test $res -ne 0 && exit $res