mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fetch: trivial cleanup

Browse Source 
Create a helper function to clear an item. The way items are cleared has
changed, and will change again soon.

No functional changes.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Felipe Contreras
2019-06-03 21:13:28 -05:00
committed by Junio C Hamano
parent 8144f09ccd
commit a8363b5719
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
builtin/fetch.c
View File

@ -285,6 +285,11 @@ static int refname_hash_exists(struct hashmap *map, const char *refname)
return !!hashmap_get_from_hash(map, strhash(refname), refname); return !!hashmap_get_from_hash(map, strhash(refname), refname);
} }
static void clear_item(struct refname_hash_entry *item)
{
oidclr(&item->oid);
}
static void find_non_local_tags(const struct ref *refs, static void find_non_local_tags(const struct ref *refs,
struct ref **head, struct ref **head,
struct ref ***tail) struct ref ***tail)
@ -318,7 +323,7 @@ static void find_non_local_tags(const struct ref *refs,
!has_sha1_file_with_flags(item->oid.hash, !has_sha1_file_with_flags(item->oid.hash,
OBJECT_INFO_QUICK) && OBJECT_INFO_QUICK) &&
!will_fetch(head, item->oid.hash)) !will_fetch(head, item->oid.hash))
oidclr(&item->oid); clear_item(item);
item = NULL; item = NULL;
continue; continue;
} }
@ -332,7 +337,7 @@ static void find_non_local_tags(const struct ref *refs,
if (item && if (item &&
!has_sha1_file_with_flags(item->oid.hash, OBJECT_INFO_QUICK) && !has_sha1_file_with_flags(item->oid.hash, OBJECT_INFO_QUICK) &&
!will_fetch(head, item->oid.hash)) !will_fetch(head, item->oid.hash))
oidclr(&item->oid); clear_item(item);
item = NULL; item = NULL;
@ -353,7 +358,7 @@ static void find_non_local_tags(const struct ref *refs,
if (item && if (item &&
!has_sha1_file_with_flags(item->oid.hash, OBJECT_INFO_QUICK) && !has_sha1_file_with_flags(item->oid.hash, OBJECT_INFO_QUICK) &&
!will_fetch(head, item->oid.hash)) !will_fetch(head, item->oid.hash))
oidclr(&item->oid); clear_item(item);
/* /*
* For all the tags in the remote_refs_list, * For all the tags in the remote_refs_list,