mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xdiff-interface: prepare for allowing early return

Browse Source 
Change the function prototype of xdiff_emit_line_fn to return an "int"
instead of "void". Change all of those functions to "return 0",
nothing checks those return values yet, and no behavior is being
changed.

In subsequent commits the interface will be changed to allow early
return via this new return value.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason
2021-04-12 19:15:24 +02:00
committed by Junio C Hamano
parent 5b0672a26e
commit a8d5eb6dc0
6 changed files with 27 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
diffcore-pickaxe.c
View File

@ -19,21 +19,22 @@ struct diffgrep_cb {
int hit;
};
static void diffgrep_consume(void *priv, char *line, unsigned long len)
static int diffgrep_consume(void *priv, char *line, unsigned long len)
{
struct diffgrep_cb *data = priv;
regmatch_t regmatch;
if (line[0] != '+' && line[0] != '-')
return;
return 0;
if (data->hit)
/*
* NEEDSWORK: we should have a way to terminate the
* caller early.
*/
return;
return 0;
data->hit = !regexec_buf(data->regexp, line + 1, len - 1, 1,
&regmatch, 0);
return 0;
}
static int diff_grep(mmfile_t *one, mmfile_t *two,