string_list: Fix argument order for string_list_insert_at_index
Update the definition and callers of string_list_insert_at_index to use the string_list as the first argument. This helps make the string_list API easier to use by being more consistent. Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
78a395d371
commit
aadceea641
@ -53,11 +53,11 @@ static int add_entry(int insert_at, struct string_list *list, const char *string
|
||||
|
||||
struct string_list_item *string_list_insert(struct string_list *list, const char *string)
|
||||
{
|
||||
return string_list_insert_at_index(-1, string, list);
|
||||
return string_list_insert_at_index(list, -1, string);
|
||||
}
|
||||
|
||||
struct string_list_item *string_list_insert_at_index(int insert_at,
|
||||
const char *string, struct string_list *list)
|
||||
struct string_list_item *string_list_insert_at_index(struct string_list *list,
|
||||
int insert_at, const char *string)
|
||||
{
|
||||
int index = add_entry(insert_at, list, string);
|
||||
|
||||
|
Reference in New Issue
Block a user