mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remote: drop checks for zero-url case

Browse Source 
Now that the previous commit removed the possibility that a "struct
remote" will ever have zero url fields, we can drop a number of
redundant checks and untriggerable code paths.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2024-06-14 06:42:03 -04:00
committed by Junio C Hamano
parent ffce821880
commit aecd794fca
6 changed files with 12 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
builtin/push.c
View File

@ -438,18 +438,9 @@ static int do_push(int flags,
}
errs = 0;
url = push_url_of_remote(remote);
if (url->nr) {
for (i = 0; i < url->nr; i++) {
struct transport *transport =
transport_get(remote, url->v[i]);
if (flags & TRANSPORT_PUSH_OPTIONS)
transport->push_options = push_options;
if (push_with_options(transport, push_refspec, flags))
errs++;
}
} else {
for (i = 0; i < url->nr; i++) {
struct transport *transport =
transport_get(remote, NULL);
transport_get(remote, url->v[i]);
if (flags & TRANSPORT_PUSH_OPTIONS)
transport->push_options = push_options;
if (push_with_options(transport, push_refspec, flags))