mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refs.c: Write reflogs for notes just like for branch heads

Browse Source 
The notes code intends to write reflog entries, but currently they are
not written because log_ref_write() checks for the refname path
explicitly.

Add refs/notes to the list of allowed paths so that notes references are
treated just like branch heads, i.e. according to core.logAllRefUpdates
and core.bare.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Acked-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael J Gruber
2010-03-29 15:05:58 +02:00
committed by Junio C Hamano
parent 4d80fa8f75
commit b2e256b0f0
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
refs.c
View File

@ -1276,6 +1276,7 @@ static int log_ref_write(const char *ref_name, const unsigned char *old_sha1,
if (log_all_ref_updates && if (log_all_ref_updates &&
(!prefixcmp(ref_name, "refs/heads/") || (!prefixcmp(ref_name, "refs/heads/") ||
!prefixcmp(ref_name, "refs/remotes/") || !prefixcmp(ref_name, "refs/remotes/") ||
!prefixcmp(ref_name, "refs/notes/") ||
!strcmp(ref_name, "HEAD"))) { !strcmp(ref_name, "HEAD"))) {
if (safe_create_leading_directories(log_file) < 0) if (safe_create_leading_directories(log_file) < 0)
return error("unable to create directory for %s", return error("unable to create directory for %s",

2
t/t3301-notes.sh
View File

@ -69,7 +69,7 @@ cat >expect <<EOF
d423f8c refs/notes/commits@{0}: notes: Notes added by 'git notes add' d423f8c refs/notes/commits@{0}: notes: Notes added by 'git notes add'
EOF EOF
test_expect_failure 'create reflog entry' ' test_expect_success 'create reflog entry' '
git reflog show refs/notes/commits >output && git reflog show refs/notes/commits >output &&
test_cmp expect output test_cmp expect output
' '