convert trivial cases to ALLOC_ARRAY
Each of these cases can be converted to use ALLOC_ARRAY or REALLOC_ARRAY, which has two advantages: 1. It automatically checks the array-size multiplication for overflow. 2. It always uses sizeof(*array) for the element-size, so that it can never go out of sync with the declared type of the array. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
850d2fec53
commit
b32fa95fd8
@ -252,7 +252,7 @@ int cmd_merge_base(int argc, const char **argv, const char *prefix)
|
||||
if (argc < 2)
|
||||
usage_with_options(merge_base_usage, options);
|
||||
|
||||
rev = xmalloc(argc * sizeof(*rev));
|
||||
ALLOC_ARRAY(rev, argc);
|
||||
while (argc-- > 0)
|
||||
rev[rev_nr++] = get_commit_reference(*argv++);
|
||||
return show_merge_base(rev, rev_nr, show_all);
|
||||
|
Reference in New Issue
Block a user