mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pack-bitmap: do not use gcc packed attribute

Browse Source 
The "__attribute__" flag may be a noop on some compilers.
That's OK as long as the code is correct without the
attribute, but in this case it is not. We would typically
end up with a struct that is 2 bytes too long due to struct
padding, breaking both reading and writing of bitmaps.

Instead of marshalling the data in a struct, let's just
provide helpers for reading and writing the appropriate
types. Besides being correct on all platforms, the result is
more efficient and simpler to read.

Signed-off-by: Karsten Blees <blees@dcon.de>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Karsten Blees
2014-11-27 00:24:01 -05:00
committed by Junio C Hamano
parent 68f4e1fc6a
commit b5007211b6
4 changed files with 29 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
csum-file.h
View File

@ -39,4 +39,15 @@ extern void sha1flush(struct sha1file *f);
extern void crc32_begin(struct sha1file *);
extern uint32_t crc32_end(struct sha1file *);
static inline void sha1write_u8(struct sha1file *f, uint8_t data)
{
sha1write(f, &data, sizeof(data));
}
static inline void sha1write_be32(struct sha1file *f, uint32_t data)
{
data = htonl(data);
sha1write(f, &data, sizeof(data));
}
#endif