submodule: add a helper to check if it is safe to write to .gitmodules
Introduce a helper function named is_writing_gitmodules_ok() to verify that the .gitmodules file is safe to write. The function name follows the scheme of is_staging_gitmodules_ok(). The two symbolic constants GITMODULES_INDEX and GITMODULES_HEAD are used to get help from the C preprocessor in preventing typos, especially for future users. This is in preparation for a future change which teaches git how to read .gitmodules from the index or from the current branch if the file is not available in the working tree. The rationale behind the check is that writing to .gitmodules requires the file to be present in the working tree, unless a brand new .gitmodules is being created (in which case the .gitmodules file would not exist at all: neither in the working tree nor in the index or in the current branch). Expose the functionality also via a "submodule-helper config --check-writeable" command, as git scripts may want to perform the check before modifying submodules configuration. Signed-off-by: Antonio Ospite <ao2@ao2.it> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
23dd8f5bb1
commit
b5c259f226
18
submodule.c
18
submodule.c
@ -50,6 +50,24 @@ int is_gitmodules_unmerged(const struct index_state *istate)
|
||||
return 0;
|
||||
}
|
||||
|
||||
/*
|
||||
* Check if the .gitmodules file is safe to write.
|
||||
*
|
||||
* Writing to the .gitmodules file requires that the file exists in the
|
||||
* working tree or, if it doesn't, that a brand new .gitmodules file is going
|
||||
* to be created (i.e. it's neither in the index nor in the current branch).
|
||||
*
|
||||
* It is not safe to write to .gitmodules if it's not in the working tree but
|
||||
* it is in the index or in the current branch, because writing new values
|
||||
* (and staging them) would blindly overwrite ALL the old content.
|
||||
*/
|
||||
int is_writing_gitmodules_ok(void)
|
||||
{
|
||||
struct object_id oid;
|
||||
return file_exists(GITMODULES_FILE) ||
|
||||
(get_oid(GITMODULES_INDEX, &oid) < 0 && get_oid(GITMODULES_HEAD, &oid) < 0);
|
||||
}
|
||||
|
||||
/*
|
||||
* Check if the .gitmodules file has unstaged modifications. This must be
|
||||
* checked before allowing modifications to the .gitmodules file with the
|
||||
|
||||
Reference in New Issue
Block a user