mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t-strvec: use va_end() to match va_start()

Browse Source 
Our check_strvec_loc() helper uses a variable argument list. When we
va_start(), we must be sure to va_end() before leaving the function.
This is required by the standard (though the effect of forgetting will
vary between platforms).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2024-05-30 02:39:32 -04:00
committed by Junio C Hamano
parent a3f0e2a064
commit b639884f9a
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
t/unit-tests/t-strvec.c
View File

@ -22,11 +22,13 @@ static void check_strvec_loc(const char *loc, struct strvec *vec, ...)
strbuf_addf(&msg, "strvec index %"PRIuMAX, (uintmax_t) nr); strbuf_addf(&msg, "strvec index %"PRIuMAX, (uintmax_t) nr);
test_assert(loc, msg.buf, 0); test_assert(loc, msg.buf, 0);
strbuf_release(&msg); strbuf_release(&msg);
va_end(ap);
return; return;
} }
nr++; nr++;
} }
va_end(ap);
check_uint(vec->nr, ==, nr); check_uint(vec->nr, ==, nr);
check_uint(vec->alloc, >=, nr); check_uint(vec->alloc, >=, nr);