set errno=0 before strtoX calls
To detect conversion failure after calls to functions like `strtod`, one can check `errno == ERANGE`. These functions are not guaranteed to set `errno` to `0` on successful conversion, however. Manual manipulation of `errno` can likely be avoided by checking that the output pointer differs from the input pointer, but that's not how other locations, such as parse.c:139, handle this issue; they set errno to 0 prior to executing the function. For every place I could find a strtoX function with an ERANGE check following it, set `errno = 0;` prior to executing the conversion function. Signed-off-by: Kyle Lippincott <spectral@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
39bf06adf9
commit
b928d57ca9
@ -35,6 +35,7 @@ int cmd_get_tar_commit_id(int argc, const char **argv UNUSED, const char *prefix
|
||||
if (header->typeflag[0] != TYPEFLAG_GLOBAL_HEADER)
|
||||
return 1;
|
||||
|
||||
errno = 0;
|
||||
len = strtol(content, &end, 10);
|
||||
if (errno == ERANGE || end == content || len < 0)
|
||||
return 1;
|
||||
|
Reference in New Issue
Block a user