mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

receive-pack: plug memory leak in update()

Browse Source 
Reported via Coverity.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin
2017-05-04 15:57:55 +02:00
committed by Junio C Hamano
parent 1efb1e9a21
commit bda6e82801
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
builtin/receive-pack.c
View File

@ -986,7 +986,8 @@ static const char *update(struct command *cmd, struct shallow_info *si)
{ {
const char *name = cmd->ref_name; const char *name = cmd->ref_name;
struct strbuf namespaced_name_buf = STRBUF_INIT; struct strbuf namespaced_name_buf = STRBUF_INIT;
const char *namespaced_name, *ret; static char *namespaced_name;
const char *ret;
struct object_id *old_oid = &cmd->old_oid; struct object_id *old_oid = &cmd->old_oid;
struct object_id *new_oid = &cmd->new_oid; struct object_id *new_oid = &cmd->new_oid;
@ -997,6 +998,7 @@ static const char *update(struct command *cmd, struct shallow_info *si)
} }
strbuf_addf(&namespaced_name_buf, "%s%s", get_git_namespace(), name); strbuf_addf(&namespaced_name_buf, "%s%s", get_git_namespace(), name);
free(namespaced_name);
namespaced_name = strbuf_detach(&namespaced_name_buf, NULL); namespaced_name = strbuf_detach(&namespaced_name_buf, NULL);
if (is_ref_checked_out(namespaced_name)) { if (is_ref_checked_out(namespaced_name)) {