cmd_bisect__helper: defer parsing no-checkout flag
cmd_bisect__helper() is intended as a temporary shim layer serving as an interface for git-bisect.sh. This function and git-bisect.sh should eventually be replaced by a C implementation, cmd_bisect(), serving as an entrypoint for all "git bisect ..." shell commands: cmd_bisect() will only parse the first token following "git bisect", and dispatch the remaining args to the appropriate function ["bisect_start()", "bisect_next()", etc.]. Thus, cmd_bisect__helper() should not be responsible for parsing flags like --no-checkout. Instead, let the --no-checkout flag remain in the argv array, so it may be evaluated alongside the other options already parsed by bisect_start(). Signed-off-by: Aaron Lipman <alipman88@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
0fe305a5d3
commit
be5fe2000d
4
bisect.h
4
bisect.h
@ -58,9 +58,7 @@ enum bisect_error {
|
||||
BISECT_INTERNAL_SUCCESS_MERGE_BASE = -11
|
||||
};
|
||||
|
||||
enum bisect_error bisect_next_all(struct repository *r,
|
||||
const char *prefix,
|
||||
int no_checkout);
|
||||
enum bisect_error bisect_next_all(struct repository *r, const char *prefix);
|
||||
|
||||
int estimate_bisect_steps(int all);
|
||||
|
||||
|
Reference in New Issue
Block a user