mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usage.c: don't copy/paste the same comment three times

Browse Source 
In ee4512ed48 (trace2: create new combined trace facility,
2019-02-22) we started with two copies of this comment,
0ee10fd129 (usage: add trace2 entry upon warning(), 2020-11-23) added
a third. Let's instead add an earlier comment that applies to all
these mostly-the-same functions.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason
2021-04-13 11:08:19 +02:00
committed by Junio C Hamano
parent 89b43f80a5
commit c00c7382dd
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
usage.c
View File

@ -55,12 +55,13 @@ static NORETURN void usage_builtin(const char *err, va_list params)
exit(129); exit(129);
} }
/*
* We call trace2_cmd_error_va() in the below functions first and
* expect it to va_copy 'params' before using it (because an 'ap' can
* only be walked once).
*/
static NORETURN void die_builtin(const char *err, va_list params) static NORETURN void die_builtin(const char *err, va_list params)
{ {
/*
* We call this trace2 function first and expect it to va_copy 'params'
* before using it (because an 'ap' can only be walked once).
*/
trace2_cmd_error_va(err, params); trace2_cmd_error_va(err, params);
vreportf("fatal: ", err, params); vreportf("fatal: ", err, params);
@ -70,10 +71,6 @@ static NORETURN void die_builtin(const char *err, va_list params)
static void error_builtin(const char *err, va_list params) static void error_builtin(const char *err, va_list params)
{ {
/*
* We call this trace2 function first and expect it to va_copy 'params'
* before using it (because an 'ap' can only be walked once).
*/
trace2_cmd_error_va(err, params); trace2_cmd_error_va(err, params);
vreportf("error: ", err, params); vreportf("error: ", err, params);
@ -81,10 +78,6 @@ static void error_builtin(const char *err, va_list params)
static void warn_builtin(const char *warn, va_list params) static void warn_builtin(const char *warn, va_list params)
{ {
/*
* We call this trace2 function first and expect it to va_copy 'params'
* before using it (because an 'ap' can only be walked once).
*/
trace2_cmd_error_va(warn, params); trace2_cmd_error_va(warn, params);
vreportf("warning: ", warn, params); vreportf("warning: ", warn, params);