mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t-reftable-block: use reftable_record_key() instead of strbuf_addstr()

Browse Source 
In the current testing setup, the record key required for many block
iterator functions is manually stored in a strbuf struct and then
passed to these functions. This is not ideal when there exists a
dedicated function to encode a record's key into a strbuf, namely
reftable_record_key(). Use this function instead of manual encoding.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Chandra Pratap
2024-08-21 18:00:55 +05:30
committed by Junio C Hamano
parent e638e9c8f3
commit c25cbcd352
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
t/unit-tests/t-reftable-block.c
View File

@ -83,8 +83,7 @@ static void t_block_read_write(void)
for (i = 0; i < N; i++) { for (i = 0; i < N; i++) {
struct block_iter it = BLOCK_ITER_INIT; struct block_iter it = BLOCK_ITER_INIT;
strbuf_reset(&want); reftable_record_key(&recs[i], &want);
strbuf_addstr(&want, recs[i].u.ref.refname);
ret = block_iter_seek_key(&it, &br, &want); ret = block_iter_seek_key(&it, &br, &want);
check_int(ret, ==, 0); check_int(ret, ==, 0);