mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Validate @recipients before using it for sendmail and Net::SMTP.

Browse Source 
Ensure that @recipients is only raw addresses when it is handed to the sendmail
binary OR Net::SMTP, otherwise BCC cases might get an extra <, or wierd stuff
might be passed to the exec.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Robin H. Johnson 2007-04-25 19:37:20 -07:00 committed by Junio C Hamano
parent 732263d411
commit c38f0247a8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
git-send-email.perl
View File

@ -449,6 +449,7 @@ sub send_message
@cc = (map { sanitize_address_rfc822($_) } @cc); @cc = (map { sanitize_address_rfc822($_) } @cc);
my $to = join (",\n\t", @recipients); my $to = join (",\n\t", @recipients);
@recipients = unique_email_list(@recipients,@cc,@bcclist); @recipients = unique_email_list(@recipients,@cc,@bcclist);
@recipients = (map { extract_valid_address($_) } @recipients);
my $date = format_2822_time($time++); my $date = format_2822_time($time++);
my $gitversion = '@@GIT_VERSION@@'; my $gitversion = '@@GIT_VERSION@@';
if ($gitversion =~ m/..GIT_VERSION../) { if ($gitversion =~ m/..GIT_VERSION../) {
@ -474,7 +475,7 @@ sub send_message
$header .= join("\n", @xh) . "\n"; $header .= join("\n", @xh) . "\n";
} }
my @sendmail_parameters = ('-i', map { extract_valid_address($_) } @recipients); my @sendmail_parameters = ('-i', @recipients);
if ($dry_run) { if ($dry_run) {
# We don't want to send the email. # We don't want to send the email.