Merge branch 'jk/write-in-full-fix'
Many codepaths did not diagnose write failures correctly when disks go full, due to their misuse of write_in_full() helper function, which have been corrected. * jk/write-in-full-fix: read_pack_header: handle signed/unsigned comparison in read result config: flip return value of store_write_*() notes-merge: use ssize_t for write_in_full() return value pkt-line: check write_in_full() errors against "< 0" convert less-trivial versions of "write_in_full() != len" avoid "write_in_full(fd, buf, len) != len" pattern get-tar-commit-id: check write_in_full() return against 0 config: avoid "write_in_full(fd, buf, len) < len" pattern
This commit is contained in:
@ -302,7 +302,7 @@ static void write_buf_to_worktree(const struct object_id *obj,
|
||||
fd = xopen(path, O_WRONLY | O_EXCL | O_CREAT, 0666);
|
||||
|
||||
while (size > 0) {
|
||||
long ret = write_in_full(fd, buf, size);
|
||||
ssize_t ret = write_in_full(fd, buf, size);
|
||||
if (ret < 0) {
|
||||
/* Ignore epipe */
|
||||
if (errno == EPIPE)
|
||||
|
||||
Reference in New Issue
Block a user