Make pull() take some implicit data as explicit arguments
Currently it's a bit weird that pull() takes a single argument describing the commit but takes the write_ref from a global variable. This makes it take that as a parameter as well, which might be nicer for the libification in the future, but especially it will make for nicer code when we implement pull()ing multiple commits at once. Signed-off-by: Petr Baudis <pasky@suse.cz> Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:

committed by
Junio C Hamano

parent
c2c487cf3a
commit
c6b69bdbc1
6
fetch.c
6
fetch.c
@ -8,9 +8,6 @@
|
||||
#include "blob.h"
|
||||
#include "refs.h"
|
||||
|
||||
const char *write_ref = NULL;
|
||||
const char *write_ref_log_details = NULL;
|
||||
|
||||
int get_tree = 0;
|
||||
int get_history = 0;
|
||||
int get_all = 0;
|
||||
@ -213,7 +210,8 @@ static int mark_complete(const char *path, const unsigned char *sha1)
|
||||
return 0;
|
||||
}
|
||||
|
||||
int pull(char *target)
|
||||
int pull(char *target, const char *write_ref,
|
||||
const char *write_ref_log_details)
|
||||
{
|
||||
struct ref_lock *lock = NULL;
|
||||
unsigned char sha1[20];
|
||||
|
Reference in New Issue
Block a user