mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

commit-graph: minimize commit_graph_data_slab access

Browse Source 
In an earlier patch, multiple struct acccesses to `graph_pos` and
`generation` were auto-converted to multiple method calls.

Since the values are fixed and commit-slab access costly, we would be
better off with storing the values as a local variable and reusing it.

Signed-off-by: Abhishek Kumar <abhishekkumar8222@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Abhishek Kumar
2020-06-17 14:44:11 +05:30
committed by Junio C Hamano
parent c49c82aa4c
commit c752ad09c4
5 changed files with 79 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
revision.c
View File

@ -3413,6 +3413,7 @@ static void init_topo_walk(struct rev_info *revs)
info->min_generation = GENERATION_NUMBER_INFINITY;
for (list = revs->commits; list; list = list->next) {
struct commit *c = list->item;
uint32_t generation;
if (parse_commit_gently(c, 1))
continue;
@ -3420,8 +3421,9 @@ static void init_topo_walk(struct rev_info *revs)
test_flag_and_insert(&info->explore_queue, c, TOPO_WALK_EXPLORED);
test_flag_and_insert(&info->indegree_queue, c, TOPO_WALK_INDEGREE);
if (commit_graph_generation(c) < info->min_generation)
info->min_generation = commit_graph_generation(c);
generation = commit_graph_generation(c);
if (generation < info->min_generation)
info->min_generation = generation;
*(indegree_slab_at(&info->indegree, c)) = 1;
@ -3472,6 +3474,7 @@ static void expand_topo_walk(struct rev_info *revs, struct commit *commit)
for (p = commit->parents; p; p = p->next) {
struct commit *parent = p->item;
int *pi;
uint32_t generation;
if (parent->object.flags & UNINTERESTING)
continue;
@ -3479,8 +3482,9 @@ static void expand_topo_walk(struct rev_info *revs, struct commit *commit)
if (parse_commit_gently(parent, 1) < 0)
continue;
if (commit_graph_generation(parent) < info->min_generation) {
info->min_generation = commit_graph_generation(parent);
generation = commit_graph_generation(parent);
if (generation < info->min_generation) {
info->min_generation = generation;
compute_indegrees_to_depth(revs, info->min_generation);
}