mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-var: constness and globalness cleanup.

Browse Source 
var.c::git_var read function did not have to return writable
strings; make it and the functions it points at return const char *
instead.

ident.c::get_ident() did not need to be global, so make it
static.

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Junio C Hamano
2005-11-21 23:44:35 -08:00
parent 9ce392f482
commit c7d77dab93
3 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ident.c
View File

@ -156,7 +156,8 @@ static int copy(char *buf, int size, int offset, const char *src)
return offset;
}
char *get_ident(const char *name, const char *email, const char *date_str)
static const char *get_ident(const char *name, const char *email,
const char *date_str)
{
static char buffer[1000];
char date[50];
@ -181,12 +182,16 @@ char *get_ident(const char *name, const char *email, const char *date_str)
return buffer;
}
char *git_author_info(void)
const char *git_author_info(void)
{
return get_ident(getenv("GIT_AUTHOR_NAME"), getenv("GIT_AUTHOR_EMAIL"), getenv("GIT_AUTHOR_DATE"));
return get_ident(getenv("GIT_AUTHOR_NAME"),
getenv("GIT_AUTHOR_EMAIL"),
getenv("GIT_AUTHOR_DATE"));
}
char *git_committer_info(void)
const char *git_committer_info(void)
{
return get_ident(getenv("GIT_COMMITTER_NAME"), getenv("GIT_COMMITTER_EMAIL"), getenv("GIT_COMMITTER_DATE"));
return get_ident(getenv("GIT_COMMITTER_NAME"),
getenv("GIT_COMMITTER_EMAIL"),
getenv("GIT_COMMITTER_DATE"));
}